[14기 신윤선] step1 돔 조작과 이벤트 핸들링으로 메뉴 관리하기 #273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md에 블랙커피 스터디 14기 함께 공부하는 팀원을 추가했습니다.
에스프레소 메뉴 추가, 수정, 삭제, 총 갯수를 구현했습니다.
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
메뉴를 등록한 뒤 생성되는 수정과 삭제 버튼에는 이벤트 위임을 사용하면 좋을것 같아요!
src/js/index.js
Outdated
| </button> | ||
| </li>` | ||
| )); | ||
|
|
There was a problem hiding this comment.
변수명을 const li 보다는 li를 생성해준다는 느낌이 들어가면 좋을것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 step1 요구사항 - 돔 조작과 이벤트 핸들링으로 메뉴 관리하기
prompt인터페이스를 활용한다.confirm인터페이스를 활용한다.😶 개선점
메뉴를 등록 후 수정 버튼을 누르면 이벤트가 실행되지 않는데 pr을 먼저 올린 후에 확인해보려고 합니다.
빈 배열 대신 객체를 넣으면 수정과 삭제 이벤트가 실행이 되는데 새로 추가할 경우에는 실행되지 않아서 이 부분을 개선할 예정입니다.